Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old dependencies #254

Closed
wants to merge 1 commit into from
Closed

Remove old dependencies #254

wants to merge 1 commit into from

Conversation

gpachecoNI
Copy link
Contributor

What does this Pull Request accomplish?

This PR eliminates old dependencies to files that got their name changed.

Why should this Pull Request be merged?

Fixes a dependency issue when trying to build MeasurmentLink Service.vipb

What testing has been done?

Build MeasurmentLink Service.vipb from a manual folder download.

@dixonjoel
Copy link
Collaborator

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g.
https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink%20Measurement%20Server%20Internal/RPC%20Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

@dixonjoel
Copy link
Collaborator

Also, I built MeasurementLink Service.vipb successfully just now.

@pbirkhol-ni
Copy link
Contributor

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g. https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink%20Measurement%20Server%20Internal/RPC%20Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

These libraries are the generated output of grpc-labview for measurement_service.proto, which hasn't changed since adding V2 support months ago. So I don't think this change is necessary.

@gpachecoNI
Copy link
Contributor Author

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g. https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink%20Measurement%20Server%20Internal/RPC%20Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g. https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink%20Measurement%20Server%20Internal/RPC%20Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

This is the PR where it got deleted.
https://github.com/ni/measurementlink-labview/pull/215/files#diff-fb0edc361b57a61843f376721801c3104db3a963b944831cfd59c8291cf97e8f

@gpachecoNI
Copy link
Contributor Author

gpachecoNI commented Aug 7, 2023 •
edited
Loading

Also, I built MeasurementLink Service.vipb successfully just now.

I am not sure how it works.. If you do git pull and build it works but if you download the zipcode and try to build it doesn't.
This is the bug nad how the error looks. https://dev.azure.com/ni/DevCentral/_workitems/edit/2478305/

@gpachecoNI
Copy link
Contributor Author

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g. https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink%20Measurement%20Server%20Internal/RPC%20Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

These libraries are the generated output of grpc-labview for measurement_service.proto, which hasn't changed since adding V2 support months ago. So I don't think this change is necessary.

How do we regenerate them then?

@pbirkhol-ni
Copy link
Contributor

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g. https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink%20Measurement%20Server%20Internal/RPC%20Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

I'm still seeing these on disk. Which PR did they supposedly get deleted in? E.g. https://github.com/ni/measurementlink-labview/blob/main/Source/Runtime/MeasurementLink%20Measurement%20Server%20Internal/RPC%20Messages/ni_measurementlink_measurement_v1_ConfigurationParameter_AnnotationsEntry.ctl

This is the PR where it got deleted. https://github.com/ni/measurementlink-labview/pull/215/files#diff-fb0edc361b57a61843f376721801c3104db3a963b944831cfd59c8291cf97e8f

That PR doesn't touch the same libraries as your PR.

@gpachecoNI gpachecoNI closed this Aug 8, 2023
@gpachecoNI
Copy link
Contributor Author

The files of the issue are any reference.. After opening the MeasurementLink Measurement Server.lvlib and closing even without saving is impossible to reproduce.

@gpachecoNI gpachecoNI deleted the users/gpacheco/FixDependencies branch August 8, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixonjoel dixonjoel Awaiting requested review from dixonjoel dixonjoel is a code owner

@csjall csjall Awaiting requested review from csjall

@aepete aepete Awaiting requested review from aepete aepete is a code owner

@pbirkhol-ni pbirkhol-ni Awaiting requested review from pbirkhol-ni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpachecoNI @dixonjoel @pbirkhol-ni